Skip to content

Conversation

stephenbessey
Copy link

This PR adds the All In One Advertising MCP Server to the registry.

About All In One Advertising

Full-service promotional products provider based in Highlands Ranch, CO. Offering thousands of customizable items including apparel, drinkware, office supplies, bags, and trade show items.

Features

  • Search promotional products catalog
  • Request custom quotes for branded merchandise
  • Get company information and contact details
  • Automated quote logging and tracking

Files Added

  • server.py - Main MCP server implementation
  • requirements.txt - Dependencies
  • README.md - Documentation and usage instructions

Testing

The server has been tested locally and imports successfully. It provides three tools:

  1. search_promotional_products - Search product catalog
  2. request_quote - Submit quote requests
  3. get_company_info - Get company details

Ready for review and approval.

Copy link

@brandon-uplevel brandon-uplevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated test review - Overall the server implementation looks good. Added a few suggestions for improvement around input validation and error handling.

async def call_tool(self, name: str, arguments: dict) -> list[TextContent]:
if name == "search_promotional_products":
return self.search_products(arguments)
elif name == "request_quote":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding input validation for the quantity parameter to ensure it meets minimum requirements before processing.

log_entry = {
"timestamp": datetime.now().isoformat(),
"reference": ref,
"request": params

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error handling here could be more specific. Consider catching specific exceptions and providing meaningful error messages.

Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Instead of putting the server code directly in this repo, could you move this to your own repo and then link to it from the Readme in this repo instead? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants